This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Switch to use greenkeeper-lockfile-update for yarn.lock file#3134
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3134 +/- ##
=======================================
Coverage 47.37% 47.37%
=======================================
Files 95 95
Lines 4000 4000
Branches 825 825
=======================================
Hits 1895 1895
Misses 2105 2105Continue to review full report at Codecov.
|
Contributor
|
Thanks! SHould i merge? |
jasonLaster
approved these changes
Jun 8, 2017
jasonLaster
left a comment
Contributor
There was a problem hiding this comment.
Wow, this is awesome
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #2978
Summary of Changes
bin/update-yarn-lock-fileTest Plan
This is one of those PRs where the test plan is merging it and seeing that it works as expected with future greenkeeper PRs.
But currently I believe we're seeing a number of errors happening with CircleCI and multiple attempts to update the yarn.lock file. Example: https://github.com/devtools-html/debugger.html/commits/greenkeeper/jest-localstorage-mock-1.2.0