This repository was archived by the owner on Jan 11, 2023. It is now read-only.
replace commonjs with imports#3131
Merged
jasonLaster merged 1 commit intoJun 8, 2017
Merged
Conversation
3bd487c to
3dc04a8
Compare
Codecov Report
@@ Coverage Diff @@
## master #3131 +/- ##
==========================================
- Coverage 47.53% 47.31% -0.22%
==========================================
Files 95 95
Lines 4012 3992 -20
Branches 825 823 -2
==========================================
- Hits 1907 1889 -18
+ Misses 2105 2103 -2
Continue to review full report at Codecov.
|
codehag
approved these changes
Jun 8, 2017
codehag
left a comment
Contributor
There was a problem hiding this comment.
looks great! can't wait for this new consistency. One minor nit
| var { PrefsHelper } = require("devtools-modules"); | ||
| const { Services: { pref } } = require("devtools-modules"); | ||
| const { isDevelopment } = require("devtools-config"); | ||
| import { Services, PrefsHelper } from "devtools-modules"; |
Contributor
There was a problem hiding this comment.
we can do { Servioces: { pref }, PrefsHelper } here i think
3dc04a8 to
8d645ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #1884