Style functions in outline view#3128
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3128 +/- ##
=======================================
Coverage 47.51% 47.51%
=======================================
Files 95 95
Lines 4003 4003
Branches 821 821
=======================================
Hits 1902 1902
Misses 2101 2101Continue to review full report at Codecov.
|
|
This looks great @amelzer! My one style critique is that it would be nice to have the hover background be full width. Other than that I think it's ready! |
|
Thank you for your feedback, @jasonLaster
However, I disagree. A full width hover would still require a little margin to the right which would require to implement a little handler for function names exceeding the width of the panel (either overflowing the container or shortening the function name). I would just leave it as it is, to be honest.
|
There was a problem hiding this comment.
Hi @amelzer
I think there is a solution here. The padding in the parent container isn't actually meaningful, and is messing things up (I implemented the bad version 😅, didn't think ahead enough ). What about doing it like this?
diff --git a/src/components/Outline.css b/src/components/Outline.css
index 15ebe5c3..e879e488 100644
--- a/src/components/Outline.css
+++ b/src/components/Outline.css
@@ -1,11 +1,11 @@
.outline-list {
+ width: 100%;
list-style-type: none;
+ padding-left: 0px;
- padding-left: 10px;
}
.outline-list__element {
color: blue;
- padding-left: 0.5rem;
+ padding-left: 1rem;
padding-right: 0.5rem;
cursor: pointer;
}| @@ -1,8 +1,15 @@ | |||
| .outline-list { | |||
| list-style-type: "-"; | |||
|
Also, it looks like our |
|
@codehag The 40px ul padding seems to be browser default. Thank you for your other suggestions, it does look quite nice now. |
|
Looks great! Thanks for your hard work! |
Associated Issue: #2901
Summary of Changes
Test Plan
Screenshots/Videos (OPTIONAL)