This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Continue conversion from commonjs to es modules#3126
Merged
jasonLaster merged 8 commits intoJun 7, 2017
Merged
Conversation
Contributor
|
We're going to 🔫 commonjs soon |
Contributor
Author
|
Any thoughts why
|
Contributor
|
Forget it. It's a trap |
Contributor
|
Let's do everything but that lol |
Codecov Report
@@ Coverage Diff @@
## master #3126 +/- ##
===========================================
+ Coverage 47.63% 66.17% +18.54%
===========================================
Files 95 76 -19
Lines 4012 2705 -1307
Branches 821 549 -272
===========================================
- Hits 1911 1790 -121
+ Misses 2101 915 -1186
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continue conversion from commonjs to es modules
Associated Issue: #1884
Summary of Changes
Refactor the following files to use ES module syntax:
Test Plan
yarn test-all