This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Bug/2963 search shows no results after switching to another tool and switching back to debugger#3121
Merged
Conversation
jasonLaster
reviewed
Jun 7, 2017
| const { query, symbolSearchOn } = this.props; | ||
| const { selectedResultIndex } = this.state; | ||
| const { query, symbolSearchResults, symbolSearchOn } = this.props; | ||
| console.log("hi"); |
| const state = State(); | ||
| expect(getSymbolSearchResults({ ui: state })).toBe( | ||
| state.symbolSearchResults | ||
| ); |
Contributor
There was a problem hiding this comment.
I like treating actions as the public interface here:
here's an actions/tests/ui test
it("should toggle the visible state of project search", () => {
const { dispatch, getState } = createStore();
expect(getProjectSearchState(getState())).toBe(false);
dispatch(actions.toggleProjectSearch());
expect(getProjectSearchState(getState())).toBe(true);
});
Contributor
Author
There was a problem hiding this comment.
I guess false / true should be replaced with something else? or maybe we drop these tests for now?
Contributor
There was a problem hiding this comment.
oh, i think this is a good "model" test
Codecov Report
@@ Coverage Diff @@
## master #3121 +/- ##
===========================================
- Coverage 66.86% 49.78% -17.08%
===========================================
Files 76 95 +19
Lines 2698 3993 +1295
Branches 544 815 +271
===========================================
+ Hits 1804 1988 +184
- Misses 894 2005 +1111
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3121 +/- ##
===========================================
- Coverage 66.28% 47.63% -18.66%
===========================================
Files 76 95 +19
Lines 2714 4012 +1298
Branches 549 821 +272
===========================================
+ Hits 1799 1911 +112
- Misses 915 2101 +1186
Continue to review full report at Codecov.
|
333973f to
727ab03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #2963