This repository was archived by the owner on Jan 11, 2023. It is now read-only.
[FunctionSearch] clear query after selecting an item #2526#3117
Merged
jasonLaster merged 4 commits intoJun 7, 2017
Conversation
… into clear_searchquery_onclose
…d-references (remark-lint)
codehag
previously approved these changes
Jun 7, 2017
Contributor
There was a problem hiding this comment.
lgtm! there is one issue though, test for AST is failing, can you check?
FAIL src/actions/tests/ast.js
● ast › setSelection › simple
expect(value).toMatchSnapshot()
Received value does not match stored snapshot 1.
- Snapshot
+ Received
@@ -1,13 +1,13 @@
Object {
"expression": "this.bazz",
- "location": SourceLocation {
- "end": Position {
+ "location": Object {
+ "end": Object {
"column": 37,
"line": 1,
},
- "start": Position {
+ "start": Object {
"column": 28,
"line": 1,
},
},
"result": undefined,
Codecov Report
@@ Coverage Diff @@
## master #3117 +/- ##
=======================================
Coverage 66.86% 66.86%
=======================================
Files 76 76
Lines 2698 2698
Branches 544 544
=======================================
Hits 1804 1804
Misses 894 894Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #2526
Summary of Changes