This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Get environment#3115
Merged
Merged
Conversation
ffecf0e to
3237cfe
Compare
codehag
approved these changes
Jun 7, 2017
codehag
left a comment
Contributor
There was a problem hiding this comment.
some nits, but looks good!
| return { | ||
| ...state, | ||
| frameScopes: { ...state.frameScopes, [selectedFrameId]: scopes }, | ||
| ...{ selectedFrameId } |
Contributor
There was a problem hiding this comment.
probably this can just be selectedFrameId
| const baz = 3; | ||
| const a = 4, b = 5; | ||
| const a = 4, | ||
| b = 5; |
Contributor
There was a problem hiding this comment.
const b = 5; would be easier to read
Contributor
Author
There was a problem hiding this comment.
agreed, it's prettier tho
3237cfe to
aac8461
Compare
Codecov Report
@@ Coverage Diff @@
## master #3115 +/- ##
==========================================
- Coverage 66.86% 65.28% -1.58%
==========================================
Files 76 76
Lines 2698 2708 +10
Branches 544 546 +2
==========================================
- Hits 1804 1768 -36
- Misses 894 940 +46
Continue to review full report at Codecov.
|
aac8461 to
c10d06d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #3072
Summary of Changes
This adds support for the new on demand frame scopes. It's important though that we don't remove the old system until the server has switched over.
Test Plan
Next Steps