Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Move getClosestExpression into worker#3104

Merged
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
ryanjduffy:feature/closest-worker
Jun 6, 2017
Merged

Move getClosestExpression into worker#3104
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
ryanjduffy:feature/closest-worker

Conversation

@ryanjduffy

@ryanjduffy ryanjduffy commented Jun 6, 2017

Copy link
Copy Markdown
Contributor

Summary of Changes

  • Moves getClosestExpression usage into the worker to decouple parser-related dependencies (babylon, parse-script-tags) from debugger.js

Test Plan

  • Run node bin/copy-assets.js to verify babylon et al aren't included in debugger.js
  • Launch debugger and verify that:
    • expressions are resolved in preview
    • getClosestExpression is called within the worker

@jasonLaster jasonLaster merged commit dc8cea3 into firefox-devtools:master Jun 6, 2017
@ryanjduffy ryanjduffy deleted the feature/closest-worker branch June 6, 2017 15:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jasonLaster jasonLaster jasonLaster approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ryanjduffy @jasonLaster