This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Use "react-dom" instead of "../../node_modules/react-dom/dist/react-dom"#3102
Merged
jasonLaster merged 1 commit intoJun 6, 2017
Merged
Conversation
Looks like we had a misconfiguration in the .babelrc
Contributor
Author
|
Also, just noticed something funny is up with our integration tests. Breakpoints tests and other tests now fail. Also on master. verrry weird |
Codecov Report
@@ Coverage Diff @@
## master #3102 +/- ##
=======================================
Coverage 66.88% 66.88%
=======================================
Files 76 76
Lines 2697 2697
Branches 544 544
=======================================
Hits 1804 1804
Misses 893 893Continue to review full report at Codecov.
|
jasonLaster
approved these changes
Jun 6, 2017
jasonLaster
left a comment
Contributor
There was a problem hiding this comment.
👍 amazing. so glad this works
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like we had a misconfiguration in the .babelrc
I did this because the weird path with
../node_modules/react-dom/dist/react-domwas doing weird things to editor component tests. I swapped it out. things seem to be working as expected.Summary of Changes
react-dom/dist/react-dom/distaddress from babel-rc../../../[etc]/node_modules/react-dom/dist/react-domtoreact-domTest Plan