This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Polish conditional breakpoint#3101
Merged
codehag merged 3 commits intoJun 6, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3101 +/- ##
=======================================
Coverage 66.88% 66.88%
=======================================
Files 76 76
Lines 2697 2697
Branches 544 544
=======================================
Hits 1804 1804
Misses 893 893Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #2918
Summary of Changes
One drawback is that conditional breakpoint is very tightly coupled with Codemirror's linewidget, where re-drawing logic resides. I turned off
noHScrollflag, but in turn it made the close button to hide when editor windows becomes to narrow (check video)Test Plan
Tell us a little a bit about how you tested your patch.
Visual test is required:
Screenshots/Videos (OPTIONAL)