Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

fix object property styling on window property names (#2946)#3099

Merged
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
jbhoosreddy:fix-object-window-props
Jun 6, 2017
Merged

fix object property styling on window property names (#2946)#3099
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
jbhoosreddy:fix-object-window-props

Conversation

@jbhoosreddy

Copy link
Copy Markdown
Contributor

Associated Issue: #2946

Summary of Changes

  • Adds additional logic so that window property names render properly on objects

Test Plan

Visual Testing

  1. Run debugger
  2. Enter expression in watch expression: a = { aLocation: 1, location: 2};
  3. Both properties should display in the same design.

Screenshots/Videos (OPTIONAL)

screen shot 2017-06-05 at 10 33 39 pm

@jbhoosreddy jbhoosreddy requested review from bomsy and jasonLaster June 6, 2017 02:34

@jasonLaster jasonLaster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. This is exactly right. Love the test

@jasonLaster jasonLaster merged commit 4377087 into firefox-devtools:master Jun 6, 2017
@jasonLaster

Copy link
Copy Markdown
Contributor

Not sure bout those aXXX cars, but I'll forgive you

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants