Add footer tabs to sources pane for outline view#3087
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3087 +/- ##
=======================================
Coverage 66.15% 66.15%
=======================================
Files 74 74
Lines 2603 2603
Branches 527 527
=======================================
Hits 1722 1722
Misses 881 881Continue to review full report at Codecov.
|
codehag
left a comment
There was a problem hiding this comment.
Hi! Awesome work, Looks really great! Thank you so much 😄
I noticed a bit of flashing when switching from outline to source tree, do you see it too? I think it was introduced earlier, just want to confirm. This only happens when the source tree has a text that is too long for the panel. It looks like the height is jumping up when the source panel is being hidden. I don't think its related to this pr though, just wanted to check if you had any ideas.
|
I accidentally broke the tab page with my css. Will add a fix.
|
|
Yes @codehag, The flicker was introduced when this feature was first added. I didn't find any good solution to resolve the issue. |
jasonLaster
left a comment
There was a problem hiding this comment.
👍
This looks great. I love the attention to detail
Associated Issue: #2901
As part of the outline view, the SVG button toggling the outline view of the sources pane has been replaced with tabs
Summary of Changes
Test Plan
Screenshots/Videos (OPTIONAL)