Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

[Frames] Show collapse row button when there are more than NUM_FRAMES_SHOWN frames#3077

Merged
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
irfanhudda:callstack-1
Jun 3, 2017
Merged

[Frames] Show collapse row button when there are more than NUM_FRAMES_SHOWN frames#3077
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
irfanhudda:callstack-1

Conversation

@irfanhudda
Copy link
Copy Markdown
Contributor

Minor fix.

When callstack has NUM_FRAMES_SHOWN frames, Collapse Rows button does nothing.

recored-2017-06-03_222808-opt screenshot from 2017-06-03 22-25-31

@jasonLaster jasonLaster merged commit 2a7668e into firefox-devtools:master Jun 3, 2017
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 3, 2017

Codecov Report

Merging #3077 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3077   +/-   ##
=======================================
  Coverage   66.15%   66.15%           
=======================================
  Files          74       74           
  Lines        2603     2603           
  Branches      527      527           
=======================================
  Hits         1722     1722           
  Misses        881      881
Impacted Files Coverage Δ
src/components/SecondaryPanes/Frames/index.js 69.86% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9c0f27...87a0b5b. Read the comment docs.

@irfanhudda irfanhudda deleted the callstack-1 branch June 3, 2017 17:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants