Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Promise fixes#3064

Merged
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
jasonLaster:promise-fixes
Jun 2, 2017
Merged

Promise fixes#3064
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
jasonLaster:promise-fixes

Conversation

@jasonLaster
Copy link
Copy Markdown
Contributor

Summary of Changes

@bomsy and I found some things while looking at HTML Elements

  • promise properties should include state, reason, and value
  • proto should be at the bottom.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2017

Codecov Report

Merging #3064 into master will increase coverage by 0.06%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3064      +/-   ##
==========================================
+ Coverage   66.11%   66.18%   +0.06%     
==========================================
  Files          74       74              
  Lines        2597     2605       +8     
  Branches      525      528       +3     
==========================================
+ Hits         1717     1724       +7     
- Misses        880      881       +1
Impacted Files Coverage Δ
src/utils/object-inspector.js 63.55% <76.92%> (+1.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4df95dc...3f07248. Read the comment docs.

@bomsy
Copy link
Copy Markdown
Contributor

bomsy commented Jun 2, 2017

LG!

* show reason, state, value
* sort __proto__ to the bottom
@jasonLaster jasonLaster merged commit 253ea74 into firefox-devtools:master Jun 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants