This repository was archived by the owner on Jan 11, 2023. It is now read-only.
[WIP] Refactor Preview#3057
Merged
Merged
Conversation
bomsy
reviewed
Jun 1, 2017
| } | ||
| const location = getTokenLocation(this.editor.codeMirror, token); | ||
| setSelection(tokenText, location); | ||
| console.log("selection", token, tokenText, location); |
bomsy
reviewed
Jun 1, 2017
| sourceMaps: any | ||
| ): Promise<Frame[]> { | ||
| if (!frames || frames.length == 0) { | ||
| if (true || !sourceMaps || !frames || frames.length == 0) { |
Contributor
There was a problem hiding this comment.
i think the true cancels out all other checks
Codecov Report
@@ Coverage Diff @@
## master #3057 +/- ##
==========================================
+ Coverage 65.17% 66.11% +0.93%
==========================================
Files 75 74 -1
Lines 2593 2597 +4
Branches 525 525
==========================================
+ Hits 1690 1717 +27
+ Misses 903 880 -23
Continue to review full report at Codecov.
|
bomsy
reviewed
Jun 1, 2017
| return state.set("selection", { | ||
| expression, | ||
| location, | ||
| result |
Contributor
There was a problem hiding this comment.
do we need to make sure updating is false here?
Contributor
Author
There was a problem hiding this comment.
hmm, i guess i should. was being cute :)
Contributor
|
looks good! just tested , it works nicely! There seems to be some lines which should be out of scope which seem to be still on when we hover. |
bomsy
approved these changes
Jun 1, 2017
This was referenced Jun 1, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #3053
Summary of Changes