[SoucesTree] Show the host domain first when the debugger opens#2957
Conversation
|
We clear the sources here so that when the user reloads we can get new ones as they stream in: https://github.com/devtools-html/debugger.html/blob/master/src/reducers/sources.js#L133-L139 We might want to change the action to CONNECT which will avoid the sources clearing |
Codecov Report
@@ Coverage Diff @@
## master #2957 +/- ##
==========================================
+ Coverage 62.62% 63.14% +0.51%
==========================================
Files 64 64
Lines 2451 2453 +2
Branches 502 502
==========================================
+ Hits 1535 1549 +14
+ Misses 916 904 -12
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2957 +/- ##
==========================================
+ Coverage 47.63% 48.16% +0.53%
==========================================
Files 98 98
Lines 4062 4067 +5
Branches 837 838 +1
==========================================
+ Hits 1935 1959 +24
+ Misses 2127 2108 -19
Continue to review full report at Codecov.
|
21d1874 to
40e4614
Compare
|
Looks great! Just fixed up the test and rebased it off master to have the most recent changes. Thanks! |
| }; | ||
| } | ||
|
|
||
| export function navigate(url) { |
wldcordeiro
left a comment
There was a problem hiding this comment.
Good changes! The navigate change is a little out of scope but I dig it. Especially with the tests too. 😄
…limil/debugger.html into showHostDomainFirstOnOpen
Associated Issue: #2448
This seems to work.
But I'm still not sure why the navigate action removes all sources from the state.