Fix default bucketing#2897
Conversation
284788c to
9c70ae2
Compare
| createNode("[default properties]", `${parentPath}/default`, defaultNodes) | ||
| createNode( | ||
| "[default properties]", | ||
| `${parentPath}/##-default`, |
There was a problem hiding this comment.
This is similar to what we do with symbol paths below.
|
one mochitest error:
|
codehag
left a comment
There was a problem hiding this comment.
One comment regarding naming, otherwise good to go
| ownProperties | ||
| ); | ||
| } else { | ||
| } else if (objProps.class == "Window") { |
| expect(paths).to.eql(["root/bar", "root/__proto__"]); | ||
| }); | ||
|
|
||
| it("window object", () => { |
There was a problem hiding this comment.
Lets give this a clearer descriptions... something like Sets default properties for the window object?
9c70ae2 to
c1671f6
Compare
Codecov Report
@@ Coverage Diff @@
## master #2897 +/- ##
==========================================
+ Coverage 60% 60.08% +0.08%
==========================================
Files 63 63
Lines 2430 2435 +5
Branches 496 497 +1
==========================================
+ Hits 1458 1463 +5
Misses 972 972
Continue to review full report at Codecov.
|
Associated Issue: #2857
Summary of Changes
We are currently showing
[default properties]incorrectly when an object happens to have a window property like location.This fixes that by explicitly checking to see if the object is a window.
Test Plan
Screenshots/Videos (OPTIONAL)