Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Fix Object Inspector toggling#2890

Merged
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
jasonLaster:fix-oi-toggling
May 15, 2017
Merged

Fix Object Inspector toggling#2890
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
jasonLaster:fix-oi-toggling

Conversation

@jasonLaster
Copy link
Copy Markdown
Contributor

@jasonLaster jasonLaster commented May 14, 2017

Summary of Changes

  • We had some issues where variables would not expand when you clicked on a label. The reason for that was that we had a special event handler for label clicks which was overriding the default.
  • There are three components to look at when testing (Scopes, Expressions, Preview). The GIF below tests all three.

codehag
codehag approved these changes May 15, 2017
View reviewed changes
Comment thread src/components/SecondaryPanes/Scopes.js
roots: scopes,
getObjectProperties: id => loadedObjects.get(id),
loadObjectProperties: loadObjectProperties,
onLabelClick: (item, { expanded, setExpanded }) => {
Copy link
Copy Markdown
Contributor

@codehag codehag May 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, looks good!

@jasonLaster jasonLaster merged commit 7b14f37 into firefox-devtools:master May 15, 2017
@jasonLaster
Copy link
Copy Markdown
Contributor Author

jasonLaster commented May 15, 2017

Killing code left and right

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@codehag codehag codehag approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jasonLaster @codehag