This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Fix remark#2880
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2880 +/- ##
==========================================
+ Coverage 58.53% 58.83% +0.29%
==========================================
Files 63 63
Lines 2390 2378 -12
Branches 490 487 -3
==========================================
Hits 1399 1399
+ Misses 991 979 -12
Continue to review full report at Codecov.
|
jasonLaster
approved these changes
May 13, 2017
Contributor
jasonLaster
left a comment
There was a problem hiding this comment.
Hey, this is fantastic. Thank you so much for the help :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi folks! 👋
Thanks for using remark! I found some issues though, where stuff wasn’t getting linted, and fixed them! Please review carefully though.
Summary of Changes