This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Make source tab's UI and tests consistent in RTL mode#2870
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2870 +/- ##
==========================================
- Coverage 58.83% 58.57% -0.26%
==========================================
Files 63 63
Lines 2378 2356 -22
Branches 487 484 -3
==========================================
- Hits 1399 1380 -19
+ Misses 979 976 -3
Continue to review full report at Codecov.
|
Contributor
|
hmm, looks like the new tab button is a bit high |
Contributor
|
Thanks for fixing storybook, that's awesome |
Author
If you're comparing to the old version, yes, it is, but that's probably because it was very misaligned before. See this:
Liked it yet? 🙃 |
Author
|
I've noticed from the last GIF that the icons were a bit shifted to the bottom. Now it's better 👌 |
Contributor
|
Thanks @diessica. The screenshots really helped. This looks really good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #2791 and #2858
Summary of Changes
document.diris configured according. (This one is important, because it was preventing styles frompostcss-bidirectionto apply, so tests weren't consistent.)Screenshots