Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Column breakpoint improvements #goodnessSquad#2867

Merged
jasonLaster merged 3 commits into
firefox-devtools:masterfrom
ohana54:column_breakpoints_10_5
May 10, 2017
Merged

Column breakpoint improvements #goodnessSquad#2867
jasonLaster merged 3 commits into
firefox-devtools:masterfrom
ohana54:column_breakpoints_10_5

Conversation

@ohana54
Copy link
Copy Markdown
Contributor

@ohana54 ohana54 commented May 10, 2017

Associated Issue: #2786

Summary of Changes

  • Changed the icon for the column breakpoint
  • Fixed enabling/disabling a column breakpoint

@jasonLaster
Copy link
Copy Markdown
Contributor

Screenshot?

@ohana54
Copy link
Copy Markdown
Contributor Author

ohana54 commented May 10, 2017

image

@codecov
Copy link
Copy Markdown

codecov Bot commented May 10, 2017

Codecov Report

Merging #2867 into master will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2867      +/-   ##
==========================================
- Coverage   58.83%   58.65%   -0.18%     
==========================================
  Files          63       63              
  Lines        2378     2368      -10     
  Branches      487      487              
==========================================
- Hits         1399     1389      -10     
  Misses        979      979
Impacted Files Coverage Δ
assets/images/Svg.js 84.61% <ø> (ø) ⬆️
src/components/Outline.js 80% <0%> (-3.79%) ⬇️
src/components/shared/previewFunction.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c39e03a...2ae4a2a. Read the comment docs.

@jasonLaster
Copy link
Copy Markdown
Contributor

Great!

@ohana54 ohana54 changed the title Changed the icon for the column breakpoint Column breakpoint improvements May 10, 2017
Copy link
Copy Markdown
Contributor

@jasonLaster jasonLaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool!

Thanks for the help

@jasonLaster jasonLaster merged commit f89332f into firefox-devtools:master May 10, 2017
@ohana54 ohana54 changed the title Column breakpoint improvements Column breakpoint improvements #goodnessSquad May 10, 2017
@ohana54
Copy link
Copy Markdown
Contributor Author

ohana54 commented May 10, 2017

You're welcome :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants