This repository was archived by the owner on Jan 11, 2023. It is now read-only.
[Breakpoints] Needs polishing in alignment#2866
Merged
jasonLaster merged 1 commit intoMay 10, 2017
Merged
Conversation
Contributor
Author
|
#goodnessSquad |
Contributor
|
Mind sharing a screenshot with a line snippet? |
Contributor
|
Mind checking with RTL on as well. Not necessary, but nice |
Codecov Report
@@ Coverage Diff @@
## master #2866 +/- ##
==========================================
- Coverage 58.83% 58.65% -0.18%
==========================================
Files 63 63
Lines 2378 2368 -10
Branches 487 487
==========================================
- Hits 1399 1389 -10
Misses 979 979
Continue to review full report at Codecov.
|
Contributor
|
You go to settings on the launchpad and turn on dir rtl
…On Wed, May 10, 2017 at 6:47 PM Gal Talmor ***@***.***> wrote:
Here's a screenshot with the line snippet
[image: image]
<https://cloud.githubusercontent.com/assets/881668/25912937/b52f9938-35c1-11e7-804a-e2d6aab75174.png>
@jasonLaster <https://github.com/jasonLaster> How do I check it with RTL
on?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2866 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPiYsbp3g0WU0uFiIuXCq44Sx4X84ogks5r4fgagaJpZM4NW-11>
.
|
Contributor
|
Looks good.
On Wed, May 10, 2017 at 6:47 PM Jason Laster <jason.laster.11@gmail.com>
wrote:
… You go to settings on the launchpad and turn on dir rtl
On Wed, May 10, 2017 at 6:47 PM Gal Talmor ***@***.***>
wrote:
> Here's a screenshot with the line snippet
> [image: image]
> <https://cloud.githubusercontent.com/assets/881668/25912937/b52f9938-35c1-11e7-804a-e2d6aab75174.png>
>
> @jasonLaster <https://github.com/jasonLaster> How do I check it with RTL
> on?
>
> —
> You are receiving this because you were mentioned.
>
>
> Reply to this email directly, view it on GitHub
> <#2866 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAPiYsbp3g0WU0uFiIuXCq44Sx4X84ogks5r4fgagaJpZM4NW-11>
> .
>
|
Contributor
Author
|
Here's a screenshot with the line snippet @jasonLaster How do I check it with RTL on? |
9554183 to
5088b33
Compare
…nment #goodnessSquad
Contributor
Author
|
There was an issue with the RTL. I've just fixed it. Here's a screenshot with RTL on |
jasonLaster
approved these changes
May 10, 2017
Contributor
jasonLaster
left a comment
There was a problem hiding this comment.
👍
Thanks @galtalmor!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #2841
Summary of Changes
Test Plan
Tested how the breakpoints menu looks on Firefox, Chrome and Edge on Windows 10.
Verified the functionality of all the items in it still work as expected (enable/disable breakpoints, remove breakpoints and clicking the file name).
Screenshots/Videos (OPTIONAL)