This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Use the license checker#2862
Merged
Merged
Conversation
2de2127 to
1f0567e
Compare
Contributor
|
@tromey i'm seeing this error:
Perhaps we need to exclude the file in our |
Contributor
Author
|
I wonder why I don't see that. I did see it in devtools-core (I updated the flow config there). Anyway, will fix. |
Contributor
Author
|
Oh, I know why. The tests fail for me locally, which I knew wasn't due to my patch, so I pushed with |
Codecov Report
@@ Coverage Diff @@
## master #2862 +/- ##
=======================================
Coverage 58.65% 58.65%
=======================================
Files 63 63
Lines 2368 2368
Branches 487 487
=======================================
Hits 1389 1389
Misses 979 979Continue to review full report at Codecov.
|
Contributor
Author
|
Had to |
jasonLaster
approved these changes
May 10, 2017
Contributor
Author
|
Ignoring the percy thing as discussed. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes