Codecov Report

Merging #2835 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2835   +/-   ##
=======================================
  Coverage   58.25%   58.25%           
=======================================
  Files          61       61           
  Lines        2338     2338           
  Branches      481      481           
=======================================
  Hits         1362     1362           
  Misses        976      976

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d359105...92ba6d1. Read the comment docs.

Thanks @diessica! Looks great, will review shortly :)

I think there are two additional edge cases:

• many tabs where we will collapse some and show the other tab dropdown button
• tabs with icons (pretty print, black box)

run yarn storybook to page through them. Just added you to our percy account so you can see all the changes

Here's a screenshot of the many tabs case, where we're no longer hiding tabs...

Thanks for reviewing! I'll look into it soon.

Hey @diessica do you think we can clean this up here too: #2791? I don't want to expand the scope too much, but it might be related enough

Yeah, can do it! :)

All cases covered now! Sorry, I wasn't familiar with percy. Really cool tool tho!

Since we're at it, I've noticed some issues with the dropdown alignment, especially while in RTL mode. Will fix them in #2791, but let's just get this one merged first.

Thanks so much for the help. I feel really good about the tabs, which are kind of our most noticeable UI actually :)