Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Fix call stack logos styling#2698

Merged
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
PunitGr:master
Apr 20, 2017
Merged

Fix call stack logos styling#2698
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
PunitGr:master

Conversation

@PunitGr

@PunitGr PunitGr commented Apr 20, 2017

Copy link
Copy Markdown
Contributor

Associated Issue: #2659

Summary of Changes

  • updated line-height for call stack logos
  • applied white color to logo when the frame is selected

Screenshot

49c3fdd2-25c3-11e7-9257-2388ce6e8a72

@PunitGr PunitGr changed the title Fix call stack logos styling #2659 Fix call stack logos styling Apr 20, 2017
@codecov

codecov Bot commented Apr 20, 2017

Copy link
Copy Markdown

Codecov Report

Merging #2698 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2698   +/-   ##
=======================================
  Coverage   58.02%   58.02%           
=======================================
  Files          55       55           
  Lines        2144     2144           
  Branches      423      423           
=======================================
  Hits         1244     1244           
  Misses        900      900

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad7f4e6...37b4761. Read the comment docs.

@jasonLaster jasonLaster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PunitGr

This is great

@jasonLaster jasonLaster merged commit 644256a into firefox-devtools:master Apr 20, 2017
DanUgelow pushed a commit to DanUgelow/debugger.html that referenced this pull request May 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants