Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Docs: Changed git clone to use https#2693

Merged
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
MFry:topic
Apr 19, 2017
Merged

Docs: Changed git clone to use https#2693
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
MFry:topic

Conversation

@MFry

@MFry MFry commented Apr 19, 2017

Copy link
Copy Markdown
Contributor

Github's recommended method for cloning is HTTPS.
This avoids the need for ssh keys.

No Associated Issue

Here's the Pull Request Doc
https://devtools-html.github.io/debugger.html/CONTRIBUTING.html#pull-requests

Summary of Changes

Updated the Quick Setup section of README and GETTING_SETUP to avoid error due to missing SSH/GPG Keys

Test Plan

Single line markdown changes.
Opened both documents and made sure they rendered properly in github and standalone.

Github's recommended method for cloning is HTTPS.
This avoids the need for ssh keys.
@codecov

codecov Bot commented Apr 19, 2017

Copy link
Copy Markdown

Codecov Report

Merging #2693 into master will decrease coverage by 0.43%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2693      +/-   ##
=========================================
- Coverage   57.83%   57.4%   -0.44%     
=========================================
  Files          55      55              
  Lines        2137    2108      -29     
  Branches      421     418       -3     
=========================================
- Hits         1236    1210      -26     
+ Misses        901     898       -3
Impacted Files Coverage Δ
src/utils/parser/utils.js 95.71% <0%> (+1.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b268b3...00fced1. Read the comment docs.

@jasonLaster jasonLaster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

@jasonLaster jasonLaster merged commit 713fad8 into firefox-devtools:master Apr 19, 2017
DanUgelow pushed a commit to DanUgelow/debugger.html that referenced this pull request May 4, 2017
Github's recommended method for cloning is HTTPS.
This avoids the need for ssh keys.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants