Show the exception message if one exists#2684
Conversation
| return dom.div({ className: "message" }, message); | ||
| } | ||
|
|
||
| const exception = pauseInfo.getIn(["why"]).get("exception").toJS(); |
There was a problem hiding this comment.
I think you should be able to do pauseInfo.getIn(["why", "exception"]) here. I'm pretty sure I did the getIn().get() pattern above for message and I think I made a mistake.
Codecov Report
@@ Coverage Diff @@
## master #2684 +/- ##
=========================================
+ Coverage 58.41% 58.9% +0.49%
=========================================
Files 55 56 +1
Lines 2164 2190 +26
Branches 427 432 +5
=========================================
+ Hits 1264 1290 +26
Misses 900 900
Continue to review full report at Codecov.
|
|
Looks like we got a test failure, which can be run in the WTR https://github.com/devtools-html/debugger.html/blob/master/src/test/integration/runner.js#L78-L84 |
|
hmmm ... tests seem to pass locally for me |
|
Hmm. I'll look
…On Fri, Apr 21, 2017 at 3:52 PM Hubert Boma Manilla < ***@***.***> wrote:
hmmm ... tests seem to pass locally for me
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2684 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPiYni8TX8Iwkws2eyVyKsHqxvhOuVlks5ryQjzgaJpZM4NBmOU>
.
|
7103625 to
e6cbed0
Compare
|
Looks like we were catching an edge case where exceptions were strings!
|
|
ahaa!! thanks. |
* Show the exception message if one exists * add jest snapshot tests for WhyPaused * do not convert to JS * Handle error strings
Associated Issue: #2677
Summary of Changes
Screenshots