This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Fix Location reps property#2674
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2674 +/- ##
=========================================
- Coverage 59.57% 57.4% -2.18%
=========================================
Files 53 55 +2
Lines 1999 2108 +109
Branches 409 418 +9
=========================================
+ Hits 1191 1210 +19
- Misses 808 898 +90
Continue to review full report at Codecov.
|
jasonLaster
approved these changes
Apr 18, 2017
jasonLaster
left a comment
Contributor
There was a problem hiding this comment.
👍
Added some tests as well. First tests for the client!
DanUgelow
pushed a commit
to DanUgelow/debugger.html
that referenced
this pull request
May 4, 2017
* Fix Location reps property * Revert index.js, SearchBar.js, sources-tree.js * Revert * add tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #1602
Summary of Changes
safeGetterValues'sgetterValueto properties'valueTest Plan
Locationin Scopes to see ifhash,host,hostname,href, etc contain the correct value.Screenshots/Videos (OPTIONAL)
Our debugger (after this patch):
Chome's debugger:
