This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Fixing Bug #2451 - AssignmentExpression Functions in search#2452
Merged
jasonLaster merged 3 commits intoMar 26, 2017
Merged
Conversation
- added assignementExpression code - added and modified test cases
Codecov Report
@@ Coverage Diff @@
## master #2452 +/- ##
==========================================
+ Coverage 54.34% 54.43% +0.09%
==========================================
Files 52 52
Lines 2015 2017 +2
Branches 390 391 +1
==========================================
+ Hits 1095 1098 +3
+ Misses 920 919 -1
Continue to review full report at Codecov.
|
jasonLaster
approved these changes
Mar 25, 2017
jasonLaster
reviewed
Mar 25, 2017
jasonLaster
left a comment
Contributor
There was a problem hiding this comment.
I added a couple tweaks feel free to discuss any change.
|
|
||
| child = function() {}; | ||
|
|
||
| (function () { 2 })(); |
Contributor
There was a problem hiding this comment.
I added this test to get our coverage up to 100%
| return parent.left.property.name; | ||
| } | ||
|
|
||
| return parent.left.name; |
Contributor
There was a problem hiding this comment.
I tweaked this block to:
- remove
isFunction(parent.right)which i believe is unnecessary - prioritize the
MemberExpressionwhich is consistent with the other type checks first
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #2451
Summary of Changes