Skip to content

fix(analytics, iOS): Update hashedPhoneNumber handling to use hex string conversion #17807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lyokone merged 2 commits into from
Mar 2, 2026
Merged

fix(analytics, iOS): Update hashedPhoneNumber handling to use hex string conversion #17807

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3913dd1
fix(analytics, iOS): Update hashedPhoneNumber handling to use hex str…
SelaseKay Oct 22, 2025
64614b6
refactor: Replace Data extension with a dedicated hex string conversi…
SelaseKay Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(analytics, iOS): Update hashedPhoneNumber handling to use hex str… 
…ing conversion and add Data extension for hex string initialization
  • Loading branch information
@SelaseKay
SelaseKay committed Oct 22, 2025
commit 3913dd1cfd0fbfa8e63cc73ed81207861d7435db
21 changes: 20 additions & 1 deletion ...analytics/ios/firebase_analytics/Sources/firebase_analytics/FirebaseAnalyticsPlugin.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ public class FirebaseAnalyticsPlugin: NSObject, FLTFirebasePluginProtocol, Flutt
Analytics.initiateOnDeviceConversionMeasurement(hashedEmailAddress: data)
}
if let hashedPhoneNumber = arguments["hashedPhoneNumber"] as? String,
let data = hashedPhoneNumber.data(using: .utf8) {
let data = Data(hexString: hashedPhoneNumber) {
Analytics.initiateOnDeviceConversionMeasurement(hashedPhoneNumber: data)
}
completion(.success(()))
Expand All @@ -162,3 +162,22 @@ public class FirebaseAnalyticsPlugin: NSObject, FLTFirebasePluginProtocol, Flutt
FLTFirebaseAnalyticsChannelName
}
}

extension Data {
init?(hexString: String) {
let len = hexString.count / 2
var data = Data(capacity: len)
var i = hexString.startIndex
for _ in 0 ..< len {
let j = hexString.index(i, offsetBy: 2)
let bytes = hexString[i ..< j]
if var num = UInt8(bytes, radix: 16) {
data.append(&num, count: 1)
} else {
return nil
}
i = j
}
self = data
}
}