Skip to content

feat(functions): migrate cloud functions Apple implementation to Swift #17232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SelaseKay merged 6 commits into from
Mar 26, 2025
Merged

feat(functions): migrate cloud functions Apple implementation to Swift #17232

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
87cbb54
feat: migrate cloud functions ios implementation to swift
SelaseKay Mar 25, 2025
0684631
chore: delete Obj C code and modifications
SelaseKay Mar 26, 2025
d687767
chore: delete obj c files in macos directory
SelaseKay Mar 26, 2025
ba80f8f
chore: add symlink to ios file in macos
SelaseKay Mar 26, 2025
c11f73f
chore: resolve comments
SelaseKay Mar 26, 2025
b5ef1b1
chore: change error code to IllegalArgumentException
SelaseKay Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/cloud_functions/cloud_functions/ios/cloud_functions.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,11 @@ Pod::Spec.new do |s|
s.license = { :file => '../LICENSE' }
s.authors = 'The Chromium Authors'
s.source = { :path => '.' }
s.source_files = 'cloud_functions/Sources/cloud_functions/**/*.{h,m}'
s.public_header_files = 'cloud_functions/Sources/cloud_functions/include/*.h'
s.source_files = 'cloud_functions/Sources/**/*.swift'
s.ios.deployment_target = '13.0'

s.swift_version = '5.0'

# Flutter dependencies
s.dependency 'Flutter'

Expand Down
5 changes: 0 additions & 5 deletions packages/cloud_functions/cloud_functions/ios/cloud_functions/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,11 +104,6 @@ let package = Package(
],
resources: [
.process("Resources"),
],
cSettings: [
.headerSearchPath("include"),
.define("LIBRARY_VERSION", to: "\"\(library_version)\""),
.define("LIBRARY_NAME", to: "\"flutter-fire-fn\""),
]
),
]
Expand Down
6 changes: 6 additions & 0 deletions ...oud_functions/cloud_functions/ios/cloud_functions/Sources/cloud_functions/Constants.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
// Copyright 2021 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// Auto-generated file. Do not edit.
public let versionNumber = "5.3.4"
Copy link
Copy Markdown
Member

@russellwheatley russellwheatley Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cloud_functions will need adding here to update Constants.swift when we publish release: https://github.com/firebase/flutterfire/blob/feat/cloud_functions_stream_support/scripts/generate_versions_spm.dart#L134

193 changes: 0 additions & 193 deletions .../cloud_functions/ios/cloud_functions/Sources/cloud_functions/FLTFirebaseFunctionsPlugin.m
View file
Open in desktop

This file was deleted.

Loading
Loading