Skip to content

fix(firestore, macos): ensure Package.swift pulls firebase-ios-sdk version from local txt file#17097

Merged
russellwheatley merged 1 commit intomainfrom
fixes-macos-firestore
Feb 17, 2025
Merged

fix(firestore, macos): ensure Package.swift pulls firebase-ios-sdk version from local txt file#17097
russellwheatley merged 1 commit intomainfrom
fixes-macos-firestore

Conversation

@MichaelVerdon
Copy link
Copy Markdown
Contributor

@MichaelVerdon MichaelVerdon commented Feb 14, 2025

Description

Make macOS Package.swift point to right files.

Related Issues

fixes #17082

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@MichaelVerdon MichaelVerdon changed the title fixes fix(macOS, Firestore): Make Package.swift point to right file. Feb 14, 2025
@russellwheatley russellwheatley changed the title fix(macOS, Firestore): Make Package.swift point to right file. fix(macOS, Firestore): ensure Package.swift pulls firebase-ios-sdk version from local txt file Feb 14, 2025
@russellwheatley russellwheatley changed the title fix(macOS, Firestore): ensure Package.swift pulls firebase-ios-sdk version from local txt file fix(firestore, macos): ensure Package.swift pulls firebase-ios-sdk version from local txt file Feb 17, 2025
@russellwheatley russellwheatley merged commit b7248e0 into main Feb 17, 2025
@russellwheatley russellwheatley deleted the fixes-macos-firestore branch February 17, 2025 09:56
@firebase firebase locked and limited conversation to collaborators Mar 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[firebase_core]: [MacOS] unable to find firebase_sdk_version.rb during Adding Swift Package Manager integration

3 participants