Skip to content

feat(firestore): add support for VectorValue #16476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lyokone merged 13 commits into from
Dec 18, 2024
Merged

feat(firestore): add support for VectorValue #16476

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3b6e835
feat(firestore): add support for VectorValue
Lyokone Nov 13, 2024
c629919
android
Lyokone Nov 13, 2024
d657ef9
fix iOS
Lyokone Dec 18, 2024
a23714b
android
Lyokone Dec 18, 2024
2317c28
fix format
Lyokone Dec 18, 2024
9713550
add to example app
Lyokone Dec 18, 2024
43b61c2
android
Lyokone Dec 18, 2024
f0eb9e6
JS
Lyokone Dec 18, 2024
18e4669
with correct JS version
Lyokone Dec 18, 2024
55f3959
format
Lyokone Dec 18, 2024
ab406e1
more tests
Lyokone Dec 18, 2024
296f3e0
fix tests
Lyokone Dec 18, 2024
cb4252d
change to test
Lyokone Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
android
  • Loading branch information
@Lyokone
Lyokone committed Dec 18, 2024
commit a23714b4440d12f9269b7e19e59cd947c7850db0
2 changes: 1 addition & 1 deletion ...main/java/io/flutter/plugins/firebase/firestore/FlutterFirebaseFirestoreMessageCodec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ protected Object readValueOfType(byte type, ByteBuffer buffer) {
readAlignment(buffer, 8);
return new GeoPoint(buffer.getDouble(), buffer.getDouble());
case DATA_TYPE_VECTOR_VALUE:
return new VectorValue(readValue(buffer));
return FieldValue.vector((double[]) Objects.requireNonNull(readValue(buffer)));
case DATA_TYPE_DOCUMENT_REFERENCE:
FirebaseFirestore firestore = (FirebaseFirestore) readValue(buffer);
final String path = (String) readValue(buffer);
Expand Down