Skip to content

fix(cloud_firestore): remove single whereIn filter assertion #13436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lyokone merged 1 commit into from
Oct 2, 2024
Merged

fix(cloud_firestore): remove single whereIn filter assertion #13436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 62 additions & 0 deletions packages/cloud_firestore/cloud_firestore/example/integration_test/query_e2e.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3891,5 +3891,67 @@ void runQueryTests() {
expect(res.docs.map((e) => e.reference), [doc2, doc3]);
});
});

group('WhereIn Filter', () {
testWidgets('Multiple whereIn filters should not trigger an assertion',
(_) async {
try {
final collection = await initializeTest('multipe-whereIn-clause');

Map<String, String> data = {};

for (int i = 1; i <= 10; i++) {
data['field$i'] = 'value$i';
}

await collection.doc().set(data);

Query<Map<String, dynamic>> query = collection;
data.forEach((field, values) {
query = query.where(field, whereIn: [values]);
});

await query.get();
} on AssertionError catch (e) {
fail('Test failed due to AssertionError: $e');
}
});

testWidgets(
'Multiple whereIn filters exceeding DNF 30 clause limit should trigger an assertion',
(_) async {
try {
final collection = await initializeTest('multipe-whereIn-clause');

await collection.doc().set({'genre': 'fiction'});
await collection.doc().set({'author': 'Author A'});

// DNF for this query = 36 (6 genres * 6 authors) exceeding the 30 clause limit
await collection.where(
'genre',
whereIn: [
'fiction',
'non-fiction',
'fantasy',
'science-fiction',
'mystery',
'thriller',
],
).where(
'author',
whereIn: [
'Author A',
'Author B',
'Author C',
'Author D',
'Author E',
'Author F',
],
).get();
} catch (error) {
expect(error, isA<FirebaseException>());
}
});
});
});
}
1 change: 0 additions & 1 deletion packages/cloud_firestore/cloud_firestore/lib/src/query.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -765,7 +765,6 @@ class _JsonQuery implements Query<Map<String, dynamic>> {
}

if (operator == 'in') {
assert(!hasIn, "You cannot use 'whereIn' filters more than once.");
assert(
!hasNotIn,
"You cannot use 'in' filters with 'not-in' filters.",
Expand Down