Skip to content

fix(firebase_auth): added supporting rawNonce for OAuth credential on Windows platform #13086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lyokone merged 2 commits into from
Jul 31, 2024
Merged

fix(firebase_auth): added supporting rawNonce for OAuth credential on Windows platform #13086

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a57cd07
fix(firebase_auth): added supporting rawNonce for OAuth credential on…
JekaNS Jul 20, 2024
bc04ec4
fix(firebase_auth): added supporting rawNonce for OAuth credential on…
JekaNS Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(firebase_auth): added supporting rawNonce for OAuth credential on… 
… Windows platform

fix formating
  • Loading branch information
@JekaNS
JekaNS committed Jul 26, 2024
commit bc04ec4fe43a2f34814b065d4e886390a4de61a7
5 changes: 2 additions & 3 deletions packages/firebase_auth/firebase_auth/windows/firebase_auth_plugin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,10 +665,9 @@ firebase::auth::Credential getCredentialFromArguments(
std::optional<std::string> rawNonce = getStringOpt(kArgumentRawNonce);
// If rawNonce provided use corresponding credential builder
// e.g. AppleID auth through the webView
if(rawNonce) {
if (rawNonce) {
return firebase::auth::OAuthProvider::GetCredential(
providerId.c_str(), idToken.value().c_str(),
rawNonce.value().c_str(),
providerId.c_str(), idToken.value().c_str(), rawNonce.value().c_str(),
accessToken ? accessToken.value().c_str() : nullptr);
} else {
return firebase::auth::OAuthProvider::GetCredential(
Expand Down