Skip to content

Support for different angular builders#8256

Merged
leoortizz merged 7 commits intofirebase:feat/do-not-block-to-use-other-buildersfrom
bboysokol:feat/angular-builders-support
Mar 5, 2025
Merged

Support for different angular builders#8256
leoortizz merged 7 commits intofirebase:feat/do-not-block-to-use-other-buildersfrom
bboysokol:feat/angular-builders-support

Conversation

@bboysokol
Copy link
Copy Markdown
Contributor

Description

This is PR which is based on another PR(#7557).
This PR supports the custom Angular builders requested in the following issues:

Scenarios Tested

Deployed Angular applications which uses following builders:

  • custom webpack
  • ngx-env builder.

Copy link
Copy Markdown
Member

@leoortizz leoortizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@leoortizz leoortizz merged commit 502614a into firebase:feat/do-not-block-to-use-other-builders Mar 5, 2025
1 check passed
leoortizz added a commit that referenced this pull request Mar 13, 2025
* feat: support custom webpack builder

* fix: lint

* feat: ngx env builder

* fix: add changelog

* support for different angular builders (#8256)

* Added handling for different angular builders

* Remove unused method from angular

* Review changes, tests and cleaning

* Removing empty jsdocs

* Fixing tests

* Update src/frameworks/angular/utils.ts

---------

Co-authored-by: Leonardo Ortiz <leo@monogram.io>

* top level describe for angular utils

---------

Co-authored-by: Leonardo Ortiz <leo@monogram.io>
Co-authored-by: Przemyslaw Sokolowski <bboy_sokol@o2.pl>
Co-authored-by: James Daniels <jamesdaniels@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants