Conversation
yuchenshi
approved these changes
Dec 13, 2024
| AND relnamespace = 'public'::regnamespace | ||
| ); | ||
| INTO _clear; | ||
| EXECUTE COALESCE(_clear, 'select now()'); |
Member
There was a problem hiding this comment.
nit:
Suggested change
| EXECUTE COALESCE(_clear, 'select now()'); | |
| EXECUTE COALESCE(_clear, 'SELECT now()'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a number of issues causing the data connect emulator to be totally broken in 13.29.0
1 - No longer provide User and Database when starting pglite. If these are passed in and the corresponding roles/databases don't exist in dataDir/--import, the emulator will crash.
2 - The ClearData query would fail with a
null value in query string of EXECUTE statementif there were no tables in the DB. This new SQL is safe in that case3 - Actually pipe thru --debug all the way to the emulator - forgot this step in yesterdays PR 🤦
Fixes #8062 8062
Scenarios Tested
curl -X POST localhost:4400/dataconnect/clearData/, confirm no crash.curl -X POST localhost:4400/dataconnect/clearData/, confirm data is cleared