Conversation
jamesdaniels
approved these changes
Apr 22, 2024
Member
jamesdaniels
left a comment
There was a problem hiding this comment.
LGTM. Add changelog and maybe see if there's a way we can defend in the test suite, don't go overboard though (and feel free to do as follow on work).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
globcall being used to remove development only files from Next.js backends(#6731) is returning posix paths, which breaks the string replace done on Windows here:firebase-tools/src/frameworks/next/index.ts
Line 661 in ae1562d
Using the
realpathoption in Windows makesglobreturn the proper paths.Fixes #7022
Scenarios Tested
Sample Commands