Skip to content

Specify user project for quota in Auth config fetch. #6819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joehan merged 8 commits into from
Feb 27, 2024
Merged

Specify user project for quota in Auth config fetch. #6819

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f3039a5
Specify user project for quota in Auth config fetch.
mbleigh Feb 27, 2024
3645ac8
update too
mbleigh Feb 27, 2024
d5a1bd9
eslint
mbleigh Feb 27, 2024
89aa6d2
Merge branch 'master' into mb-auth-quota
mbleigh Feb 27, 2024
577cb4a
changelog
mbleigh Feb 27, 2024
64d4acb
Merge branch 'mb-auth-quota' of github.com:firebase/firebase-tools in…
mbleigh Feb 27, 2024
a4c3f5f
Merge branch 'master' into mb-auth-quota
joehan Feb 27, 2024
f23ad2e
formatting
mbleigh Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* Fixed quota attribution for Firebase Auth API calls.
Comment thread
joehan marked this conversation as resolved.
Outdated
6 changes: 5 additions & 1 deletion src/gcp/auth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ const apiClient = new Client({ urlPrefix: identityOrigin, auth: true });
export async function getAuthDomains(project: string): Promise<string[]> {
const res = await apiClient.get<{ authorizedDomains: string[] }>(
`/admin/v2/projects/${project}/config`,
{ headers: { "x-goog-user-project": project } },
);
return res.body.authorizedDomains;
}
Expand All @@ -28,7 +29,10 @@ export async function updateAuthDomains(project: string, authDomains: string[]):
>(
`/admin/v2/projects/${project}/config`,
{ authorizedDomains: authDomains },
{ queryParams: { update_mask: "authorizedDomains" } },
{
queryParams: { update_mask: "authorizedDomains" },
headers: { "x-goog-user-project": project },
},
);
return res.body.authorizedDomains;
}