Repository navigation
Fix a Firestore transaction crash if getDocument was called after terminateWithCompletion. - #8760
Merged
Merged
Conversation
…irestore terminateWithCompletion]` and add a test for it.
Collaborator
Binary Size ReportAffected SDKs
Test Logs
|
Collaborator
Coverage ReportAffected SDKs
Test Logs
|
schmidt-sebastian
approved these changes
Oct 7, 2021
schmidt-sebastian
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding the test. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a crash if
[FIRTransaction getDocument]was called after[FIRFirestore terminateWithCompletion], and add a test for it.The crash error message looked like this:
The crash was due to
terminateWithCompletiontriggering the reference count of ashared_ptrto theDatastoreobject to reach zero, causing the object to be deleted. TheTransactionclass, however, stored a raw pointer to thisDatastoreobject and calling[FIRTransaction getDocument]attempted to use this dangling pointer.The fix was to change the
Datastore*instance variable to astd::weak_ptr<Datastore>in theTransactionclass and gracefully handle the situation where it got nulled out.This bug also affects the C++ SDK and the Unity SDK and those SDKs will get this fix automatically once they upgrade their dependencies. Googlers can see b/201415845 for details.