Skip to content

correct timezone proto key - #3132

Merged
charlotteliang merged 1 commit into
masterfrom
fcm-timezone
Jun 7, 2019
Merged

charlotteliang merged 1 commit into
masterfrom
fcm-timezone

Conversation

@charlotteliang

Copy link
Copy Markdown
Member

The timezone proto key passed in is in wrong format.

@christibbs christibbs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending Travis.

@paulb777 paulb777 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis was good except for a flake.

@charlotteliang
charlotteliang merged commit f0f9d70 into master Jun 7, 2019
@charlotteliang
charlotteliang deleted the fcm-timezone branch June 7, 2019 19:29
@firebase firebase locked and limited conversation to collaborators Oct 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants