Repository navigation
Remove FirebaseStorageInternal - #10118
Merged
Merged
Conversation
Collaborator
Generated by 🚫 Danger |
ncooke3
approved these changes
Aug 25, 2022
paulb777
added a commit
that referenced
this pull request
Aug 26, 2022
paulb777
added a commit
that referenced
this pull request
Sep 1, 2022
paulb777
added a commit
that referenced
this pull request
Sep 7, 2022
paulb777
added a commit
that referenced
this pull request
Sep 14, 2022
paulb777
added a commit
that referenced
this pull request
Sep 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that FirebaseStorage is completely written in Swift, remove all remnants of the Objective C FirebaseStorageInternal.
Since FirebaseStorage now requires GTMSessionFetcher 2.1, it's now incompatible with GoogleSignIn whose GTMAppAuth's dependency is locked to GTMSessionFetcher 1.x (google/GTMAppAuth#174)
I worked around this by pushing GTMSessionFetcher 2.x compatible versions of GoogleSignIn and GTMAppAuth to SpecsDev.
The GoogleMLKit integration test is disabled until it updates to Firebase 10 and GTMSessionFetcher 2.x