Supporting streaming API calls to callable functions#1629
Merged
Conversation
blidd-google
approved these changes
Nov 7, 2024
Contributor
blidd-google
left a comment
There was a problem hiding this comment.
LGTM, left some minor comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The feature is not complete, but is fully backward compatible and not a risk to existing users.
One unintended change:
Since we are introducing optional 2nd argument the v2 callable handlers, we can no longer sniff the args length to differentiate v1 and v2 handlers. This requires us to explicitly set the version when invoking the the common HTTP callable wrapper.