Repository navigation
[crashlytics] Specify the executor when calling onFailureListener - #6535
Merged
Merged
Conversation
To prevent unwanted executions in the main thread, callbacks should specify the executor explicitly.
Contributor
Release note changesThe following release notes were modified. Please ensure they look correct. Release Notesfirebase-crashlytics### {{crashlytics}} version 19.2.2 {: #crashlytics_v19-2-2}
* {{fixed}} Execute failure listener outside the main thread GitHub [#6535](//github.com/firebase/firebase-android-sdk/issues/6535){: .external}
#### {{crashlytics}} Kotlin extensions version 19.2.2 {: #crashlytics-ktx_v19-2-2}
The Kotlin extensions library transitively includes the updated
`firebase-crashlytics` library. The Kotlin extensions library has no additional
updates.
|
Contributor
Vertex AI Mock Responses Check
|
Contributor
Test Results 8 files - 1 028 8 suites - 1 028 36s ⏱️ - 36m 8s Results for commit 8045f22. ± Comparison against base commit 1b24b82. This pull request removes 5851 tests.♻️ This comment has been updated with latest results. |
Collaborator
Coverage Report 1Affected ProductsTest Logs |
Collaborator
Size Report 1Affected Products
Test Logs |
mrober
approved these changes
Nov 25, 2024
Taofiq-Anam
approved these changes
Dec 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To prevent unwanted executions in the main thread, callbacks should specify the executor explicitly.