Various improvements to Bloom Filter work#4986
Merged
dconeybe merged 1 commit intomila/BloomFilterfrom May 8, 2023
Merged
Conversation
Collaborator
Generated by 🚫 Danger |
Collaborator
Coverage Report 1Affected Products
Test Logs |
Collaborator
Size Report 1Affected Products
Test Logs |
Collaborator
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Startup time comparison between the CI merge commit (8628b99) and the base commit (2573baa) are not available. No macrobenchmark data found for the base commit (2573baa). Analysis for the CI merge commit (8628b99) can be found at: |
milaGGL
reviewed
May 8, 2023
| if (bitmap == null) { | ||
| throw new NullPointerException("Bitmap cannot be null."); | ||
| } | ||
| /** |
Contributor
There was a problem hiding this comment.
Thank you for adding the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a small selection of improvements to the bloom filter work in #4982.
Improvements include
QueryTest.javaandTestingHooksUtil.javavia./gradlew googleJavaFormat.BloomFilterclassfinal.BloomFilternow takesByteStringinstead ofbyte[]to avoid making unnecessary copies of the byte array; it also models a read-only byte array better thanbyte[].BloomFilter.create()added to more idiomatically provide the "validation" logic of the bloom filter's parameters.BloomFiltertoString() and exception tests made less brittle by only validating a substring of the exception's message, rather than the entire message (Googlers see go/java-testing/exceptions).