Skip to content

Add support for GWP-ASan crashes#4721

Merged
kmandrika merged 3 commits intomasterfrom
gwp-asan-support
Mar 9, 2023
Merged

Add support for GWP-ASan crashes#4721
kmandrika merged 3 commits intomasterfrom
gwp-asan-support

Conversation

@kmandrika
Copy link
Copy Markdown
Contributor

@kmandrika kmandrika commented Feb 27, 2023

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 27, 2023 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended.

@google-oss-bot
Copy link
Copy Markdown
Collaborator

google-oss-bot commented Feb 27, 2023

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Copy Markdown
Collaborator

google-oss-bot commented Feb 27, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-crashlytics

    Overall coverage changed from 10.15% (7bbe823) to 10.13% (58387d4) by -0.03%.

    FilenameBase (7bbe823)Merge (58387d4)Diff
    AutoCrashlyticsReportEncoder.java57.88%57.82%-0.05%
    CrashlyticsController.java18.29%17.77%-0.52%
    CrashlyticsNativeComponentDeferredProxy.java25.81%25.00%-0.81%
    CrashlyticsReport.java2.75%2.73%-0.03%
    CrashlyticsReportJsonTransform.java1.19%1.18%-0.01%
    CrashlyticsReportPersistence.java3.19%3.16%-0.03%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/L570nRXJxe.html

@google-oss-bot
Copy link
Copy Markdown
Collaborator

google-oss-bot commented Feb 27, 2023 •
edited
Loading

Size Report 1

Affected Products

  • firebase-crashlytics

    TypeBase (7bbe823)Merge (58387d4)Diff
    aar349 kB350 kB+1.17 kB (+0.3%)
    apk (aggressive)244 kB245 kB+152 B (+0.1%)
    apk (release)1.48 MB1.48 MB+348 B (+0.0%)

  • firebase-crashlytics-ndk

    TypeBase (7bbe823)Merge (58387d4)Diff
    aar1.65 MB1.66 MB+3.41 kB (+0.2%)
    apk (aggressive / arm64-v8a)1.41 MB1.41 MB+4.10 kB (+0.3%)
    apk (aggressive / armeabi-v7a)885 kB889 kB+4.10 kB (+0.5%)
    apk (aggressive / x86)1.39 MB1.39 MB+4.10 kB (+0.3%)
    apk (aggressive / x86_64)1.45 MB1.46 MB+4.10 kB (+0.3%)
    apk (release / arm64-v8a)2.64 MB2.64 MB+4.10 kB (+0.2%)
    apk (release / armeabi-v7a)2.11 MB2.12 MB+4.10 kB (+0.2%)
    apk (release / x86)2.62 MB2.62 MB+4.10 kB (+0.2%)
    apk (release / x86_64)2.68 MB2.69 MB+4.10 kB (+0.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/B1f6NDrtwp.html

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 27, 2023 •
edited
Loading

Unit Test Results

  6 files   -    776    6 suites   - 776   18s ⏱️ - 35m 12s
18 tests  - 4 786  18 ✔️  - 4 765  0 💤  - 21  0 ❌ ±0 
36 runs   - 9 481  36 ✔️  - 9 439  0 💤  - 42  0 ❌ ±0 

Results for commit 62db5c4. ± Comparison against base commit bb62df1.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Copy Markdown
Collaborator

google-oss-bot commented Feb 27, 2023 •
edited
Loading

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-cls

    DeviceStatisticsDistributions
    oriole-32
    Percentile7bbe82358387d4DiffSignificant (?)
    p1010.9 ±4 ms10.6 ±3 ms-339 μs (-3.1%)NO
    p2511.8 ±4 ms11.3 ±4 ms-545 μs (-4.6%)NO
    p5013.1 ±5 ms12.4 ±4 ms-762 μs (-5.8%)NO
    p7514.7 ±6 ms13.8 ±4 ms-881 μs (-6.0%)NO
    p9016.5 ±7 ms15.2 ±4 ms-1.26 ms (-7.7%)NO

    20 test runs in comparison
    CommitTest Runs
    7bbe823
    • 2023-03-09_01:55:45.740649_QnTc
    • 2023-03-09_01:55:45.746670_nrrB
    • 2023-03-09_01:55:45.746692_FSIU
    • 2023-03-09_01:55:45.746701_BFXo
    • 2023-03-09_01:55:45.746708_ihiE
    • 2023-03-09_01:55:45.746714_HYpM
    • 2023-03-09_01:55:45.746721_BYPZ
    • 2023-03-09_01:55:45.746727_pUhi
    • 2023-03-09_01:55:45.746733_LmsU
    • 2023-03-09_01:55:45.746739_KMAR
    58387d4
    • 2023-03-09_20:13:29.478081_pQFe
    • 2023-03-09_20:13:29.482281_TEsM
    • 2023-03-09_20:13:29.482313_wnnN
    • 2023-03-09_20:13:29.482340_heiJ
    • 2023-03-09_20:13:29.482356_sNSh
    • 2023-03-09_20:13:29.482371_MRFq
    • 2023-03-09_20:13:29.482386_WMGO
    • 2023-03-09_20:13:29.482401_UmtP
    • 2023-03-09_20:13:29.482417_ooxS
    • 2023-03-09_20:13:29.482432_CtkO
    redfin-30
    Percentile7bbe82358387d4DiffSignificant (?)
    p1012.4 ±4 ms12.3 ±5 ms-92.8 μs (-0.7%)NO
    p2512.8 ±4 ms12.9 ±6 ms+85.8 μs (+0.7%)NO
    p5013.8 ±5 ms13.9 ±7 ms+119 μs (+0.9%)NO
    p7515.0 ±6 ms15.8 ±8 ms+792 μs (+5.3%)NO
    p9016.6 ±6 ms18.2 ±9 ms+1.64 ms (+9.9%)NO

    20 test runs in comparison
    CommitTest Runs
    7bbe823
    • 2023-03-09_01:55:45.740649_QnTc
    • 2023-03-09_01:55:45.746670_nrrB
    • 2023-03-09_01:55:45.746692_FSIU
    • 2023-03-09_01:55:45.746701_BFXo
    • 2023-03-09_01:55:45.746708_ihiE
    • 2023-03-09_01:55:45.746714_HYpM
    • 2023-03-09_01:55:45.746721_BYPZ
    • 2023-03-09_01:55:45.746727_pUhi
    • 2023-03-09_01:55:45.746733_LmsU
    • 2023-03-09_01:55:45.746739_KMAR
    58387d4
    • 2023-03-09_20:13:29.478081_pQFe
    • 2023-03-09_20:13:29.482281_TEsM
    • 2023-03-09_20:13:29.482313_wnnN
    • 2023-03-09_20:13:29.482340_heiJ
    • 2023-03-09_20:13:29.482356_sNSh
    • 2023-03-09_20:13:29.482371_MRFq
    • 2023-03-09_20:13:29.482386_WMGO
    • 2023-03-09_20:13:29.482401_UmtP
    • 2023-03-09_20:13:29.482417_ooxS
    • 2023-03-09_20:13:29.482432_CtkO

  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile7bbe82358387d4DiffSignificant (?)
    p10197 ±9.7 ms207 ±39 ms+10.0 ms (+5.1%)NO
    p25205 ±11 ms214 ±42 ms+9.30 ms (+4.5%)NO
    p50217 ±19 ms224 ±45 ms+6.66 ms (+3.1%)NO
    p75232 ±30 ms234 ±50 ms+2.37 ms (+1.0%)NO
    p90245 ±34 ms246 ±53 ms+883 μs (+0.4%)NO

    20 test runs in comparison
    CommitTest Runs
    7bbe823
    • 2023-03-09_01:55:45.740649_QnTc
    • 2023-03-09_01:55:45.746670_nrrB
    • 2023-03-09_01:55:45.746692_FSIU
    • 2023-03-09_01:55:45.746701_BFXo
    • 2023-03-09_01:55:45.746708_ihiE
    • 2023-03-09_01:55:45.746714_HYpM
    • 2023-03-09_01:55:45.746721_BYPZ
    • 2023-03-09_01:55:45.746727_pUhi
    • 2023-03-09_01:55:45.746733_LmsU
    • 2023-03-09_01:55:45.746739_KMAR
    58387d4
    • 2023-03-09_20:13:29.478081_pQFe
    • 2023-03-09_20:13:29.482281_TEsM
    • 2023-03-09_20:13:29.482313_wnnN
    • 2023-03-09_20:13:29.482340_heiJ
    • 2023-03-09_20:13:29.482356_sNSh
    • 2023-03-09_20:13:29.482371_MRFq
    • 2023-03-09_20:13:29.482386_WMGO
    • 2023-03-09_20:13:29.482401_UmtP
    • 2023-03-09_20:13:29.482417_ooxS
    • 2023-03-09_20:13:29.482432_CtkO
    redfin-30
    Percentile7bbe82358387d4DiffSignificant (?)
    p10229 ±3 ms251 ±5 ms+21.8 ms (+9.5%)MAYBE
    p25234 ±3 ms257 ±6 ms+22.2 ms (+9.5%)MAYBE
    p50241 ±4 ms264 ±6 ms+23.0 ms (+9.5%)MAYBE
    p75249 ±4 ms274 ±7 ms+24.6 ms (+9.9%)MAYBE
    p90258 ±5 ms288 ±9.6 ms+30.0 ms (+11.6%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    7bbe823
    • 2023-03-09_01:55:45.740649_QnTc
    • 2023-03-09_01:55:45.746670_nrrB
    • 2023-03-09_01:55:45.746692_FSIU
    • 2023-03-09_01:55:45.746701_BFXo
    • 2023-03-09_01:55:45.746708_ihiE
    • 2023-03-09_01:55:45.746714_HYpM
    • 2023-03-09_01:55:45.746721_BYPZ
    • 2023-03-09_01:55:45.746727_pUhi
    • 2023-03-09_01:55:45.746733_LmsU
    • 2023-03-09_01:55:45.746739_KMAR
    58387d4
    • 2023-03-09_20:13:29.478081_pQFe
    • 2023-03-09_20:13:29.482281_TEsM
    • 2023-03-09_20:13:29.482313_wnnN
    • 2023-03-09_20:13:29.482340_heiJ
    • 2023-03-09_20:13:29.482356_sNSh
    • 2023-03-09_20:13:29.482371_MRFq
    • 2023-03-09_20:13:29.482386_WMGO
    • 2023-03-09_20:13:29.482401_UmtP
    • 2023-03-09_20:13:29.482417_ooxS
    • 2023-03-09_20:13:29.482432_CtkO

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/sswcCQE2UP/index.html

@kmandrika kmandrika requested a review from mrober March 8, 2023 20:02
@kmandrika kmandrika merged commit b010838 into master Mar 9, 2023
@kmandrika kmandrika deleted the gwp-asan-support branch March 9, 2023 20:29
@firebase firebase locked and limited conversation to collaborators Apr 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mrober mrober mrober approved these changes

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kmandrika @google-oss-bot @mrober