Skip to content

Handle exception when registering too many receivers in Crashlytics. #2504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrober merged 1 commit into from
Mar 12, 2021
Merged

Handle exception when registering too many receivers in Crashlytics. #2504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ...rc/androidTest/java/com/google/firebase/crashlytics/internal/common/BatteryStateTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,18 @@ public void testNullIntent() {
assertEquals(1, state.getBatteryVelocity());
}

public void testTooManyReceivers() {
Context mockContext = mock(Context.class);
when(mockContext.registerReceiver(isNull(), any()))
.thenThrow(new IllegalStateException("Too many receivers"));

BatteryState state = BatteryState.get(mockContext);

assertNull(state.getBatteryLevel());
assertFalse(state.isPowerConnected());
assertEquals(1, state.getBatteryVelocity());
}

public void testEmptyIntent() {
final Context mockContext = mock(Context.class);
when(mockContext.registerReceiver(isNull(), any())).thenReturn(new Intent());
Expand Down
16 changes: 11 additions & 5 deletions ...ashlytics/src/main/java/com/google/firebase/crashlytics/internal/common/BatteryState.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import android.content.Intent;
import android.content.IntentFilter;
import android.os.BatteryManager;
import com.google.firebase.crashlytics.internal.Logger;

/** A utility class representing the state of the battery. */
class BatteryState {
Expand Down Expand Up @@ -66,11 +67,16 @@ public static BatteryState get(Context context) {
boolean powerConnected = false;
Float level = null;

final IntentFilter ifilter = new IntentFilter(Intent.ACTION_BATTERY_CHANGED);
final Intent batteryStatusIntent = context.registerReceiver(null, ifilter);
if (batteryStatusIntent != null) {
powerConnected = isPowerConnected(batteryStatusIntent);
level = getLevel(batteryStatusIntent);
try {
final IntentFilter ifilter = new IntentFilter(Intent.ACTION_BATTERY_CHANGED);
final Intent batteryStatusIntent = context.registerReceiver(/*receiver=*/ null, ifilter);
if (batteryStatusIntent != null) {
powerConnected = isPowerConnected(batteryStatusIntent);
level = getLevel(batteryStatusIntent);
}
} catch (IllegalStateException ex) {
// This happens on some devices when the app registers too many receivers.
Logger.getLogger().e("An error occurred getting battery state.", ex);
}

return new BatteryState(level, powerConnected);
Expand Down