Skip to content

Fix: corrected ValueError message#338

Merged
hiranya911 merged 1 commit into
firebase:masterfrom
bertdida:master
Sep 5, 2019
Merged

Fix: corrected ValueError message#338
hiranya911 merged 1 commit into
firebase:masterfrom
bertdida:master

Conversation

@bertdida
Copy link
Copy Markdown
Contributor

@bertdida bertdida commented Sep 5, 2019

Used type of check_revoked variable instead of app for ValueError message.

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@bertdida
Copy link
Copy Markdown
Contributor Author

bertdida commented Sep 5, 2019

@googlebot I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@hiranya911 hiranya911 self-assigned this Sep 5, 2019
Copy link
Copy Markdown
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @bertdida for the fix.

@hiranya911 hiranya911 merged commit 5d4d6cb into firebase:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants