Skip to content

Re-organizing Auth Unit Tests #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hiranya911 merged 3 commits into from
Apr 5, 2018
Merged

Re-organizing Auth Unit Tests #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be37ea8
Re-organizing auth unit tests
hiranya911 Apr 4, 2018
4532a81
Moving _request to TokenVerifier class
hiranya911 Apr 4, 2018
fbcd4e7
Updated tests
hiranya911 Apr 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions firebase_admin/_token_gen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@

from firebase_admin import credentials

# Provided for overriding during tests.
_request = transport.requests.Request()

# ID token constants
ID_TOKEN_ISSUER_PREFIX = 'https://securetoken.google.com/'
Expand All @@ -36,11 +34,11 @@
# Session cookie constants
COOKIE_ISSUER_PREFIX = 'https://session.firebase.google.com/'
COOKIE_CERT_URI = 'https://www.googleapis.com/identitytoolkit/v3/relyingparty/publicKeys'
MIN_SESSION_COOKIE_DURATION_SECONDS = datetime.timedelta(minutes=5).total_seconds()
MAX_SESSION_COOKIE_DURATION_SECONDS = datetime.timedelta(days=14).total_seconds()
MIN_SESSION_COOKIE_DURATION_SECONDS = int(datetime.timedelta(minutes=5).total_seconds())
MAX_SESSION_COOKIE_DURATION_SECONDS = int(datetime.timedelta(days=14).total_seconds())

# Custom token constants
MAX_TOKEN_LIFETIME_SECONDS = datetime.timedelta(hours=1).total_seconds()
MAX_TOKEN_LIFETIME_SECONDS = int(datetime.timedelta(hours=1).total_seconds())
FIREBASE_AUDIENCE = ('https://identitytoolkit.googleapis.com/google.'
'identity.identitytoolkit.v1.IdentityToolkit')
RESERVED_CLAIMS = set([
Expand Down Expand Up @@ -152,6 +150,7 @@ class TokenVerifier(object):
"""Verifies ID tokens and session cookies."""

def __init__(self, app):
self.request = transport.requests.Request()
self._id_token_verifier = _JWTVerifier(
project_id=app.project_id, short_name='ID token',
operation='verify_id_token()',
Expand All @@ -164,10 +163,10 @@ def __init__(self, app):
cert_url=COOKIE_CERT_URI, issuer=COOKIE_ISSUER_PREFIX)

def verify_id_token(self, id_token):
return self._id_token_verifier.verify(id_token)
return self._id_token_verifier.verify(id_token, self.request)

def verify_session_cookie(self, cookie):
return self._cookie_verifier.verify(cookie)
return self._cookie_verifier.verify(cookie, self.request)


class _JWTVerifier(object):
Expand All @@ -185,7 +184,7 @@ def __init__(self, **kwargs):
else:
self.articled_short_name = 'a {0}'.format(self.short_name)

def verify(self, token):
def verify(self, token, request):
"""Verifies the signature and data for the provided JWT."""
token = token.encode('utf-8') if isinstance(token, six.text_type) else token
if not isinstance(token, six.binary_type) or not token:
Expand Down Expand Up @@ -258,7 +257,7 @@ def verify(self, token):

verified_claims = google.oauth2.id_token.verify_token(
token,
request=_request,
request=request,
audience=self.project_id,
certs_url=self.cert_url)
verified_claims['uid'] = verified_claims['sub']
Expand Down
Loading