Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: firebase/firebase-admin-python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c5e66f8
Choose a base ref
...
head repository: firebase/firebase-admin-python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c84ce6f
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Jul 6, 2026

  1. feat(dataconnect): Implemented Data Connect service client and compre… 

    …hensive test suite (#955)

* feat(fdc): Added unit tests for Data Connect client factory and _DataConnectService

* Testing ConnectorConfig, client function, and service

* refactor(dataconnect): Addressed code review feedback and standardized docstrings/synatx

Refactored test suite to use module-level BASE_CONFIG and added parameterized client caching tests.

* feat(dataconnect): Implemented foundational Data Connect client and service architecture

Implemented ConnectorConfig dataclass, DataConnect client instance, _DataConnectService caching layer, and public client() factory function. Fixed mock recursion in test_client_successful using lambda delegation in test_data_connect.py.

* chore(dataconnect): Standardized test suite formatting to achieve 10.00/10 linter score

* refactor(dataconnect): Addressed code review feedback and optimized test suite structure

Removed duplicate client factory caching tests, moved app service loader test to unit test class, added connector property validation, and formatted parameter lists.

* chore(fdc): Updated documentation and moved integration tests
Added missing copyright headers and improved docstrings with proper formatting in dataconnect.py. Moved TestDataConnectServiceIntegration from tests/test_data_connect.py into a dedicated integration test file under integration/test_data_connect.py.

* refactor(fdc): Returned TestDataConnectServiceIntegration to tests/test_data_connect.py
Moved TestDataConnectServiceIntegration back to tests/test_data_connect.py and removed integration/test_data_connect.py.

* test(fdc): Renamed integration test class to TestDataConnectServiceWorkflow
Renamed TestDataConnectServiceIntegration to TestDataConnectServiceWorkflow in tests/test_data_connect.py to clarify that it is an in-memory unit/functional test rather than a network integration test.
    @mk2023
    mk2023 authored Jul 6, 2026
    Configuration menu
    Copy the full SHA
    c84ce6f View commit details
    Browse the repository at this point in the history
Loading